Closed
Conversation
Contributor
|
You'll want to align this to #3049 which I just merged. |
Contributor
Author
|
Indeed. If only it could be made more generic.
BTW, are you sure your patch works as intended? Because by adding your condition to the if branch you fall into the else branch. Might not be what you had in mind.
Le 24 octobre 2024 13:46:31 GMT+02:00, Jim King ***@***.***> a écrit :
…You'll want to align this to #3049 which I just merged.
--
Reply to this email directly or view it on GitHub:
#3055 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Contributor
Author
jeking3
approved these changes
Nov 6, 2024
Contributor
jeking3
left a comment
jeking3
left a comment
There was a problem hiding this comment.
Thanks for fixing that up.
|
any movement on this? would be great to have this change in |
Member
|
Still rebase needed |
Member
|
Despite the conflict, there is technically no change when compared against the current master. The equivalent of merge & conflict resolution is an empty diff. So I would consider this done. Feel free to open another PR when I overlooked sth. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for boringssl where OPENSSL_thread_stop is not implemented/defined and CONF_modules_unload is also missing. Fixed by removing these calls when boringssl is in use.
[skip ci]anywhere in the commit message to free up build resources.